Improve usage of Provider API #94
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit improves Gradle configuration avoidance and prepares the plugin
for configuration cache support by implementing the Provider API throughout
the codebase.
Key improvements:
1. Fixed eager task configuration:
- Removed .configure() calls on tasks.named() in NebulaFacetPlugin
- Changed from tasks.named('build').configure() to tasks.named('build', action)
- Changed from tasks.named('check').configure() to tasks.named('check', action)
- These changes eliminate eager task configuration and improve build performance
2. Converted properties to use Provider API:
- FacetDefinition.parentSourceSet now uses Property<String>
- TestFacetDefinition.testTaskName now uses Property<String>
- TestFacetDefinition.includeInCheckLifecycle now uses Property<Boolean>
- Added @Inject constructors with ObjectFactory parameters
- Provides better configuration cache compatibility
3. Updated object creation:
- All FacetDefinition and TestFacetDefinition instances now created via
project.objects.newInstance() for proper dependency injection
- Ensures Provider properties are correctly initialized
Benefits:
- Improved build performance through better configuration avoidance
- Reduced configuration time by avoiding eager task realization
- Better preparation for configuration cache support
- More idiomatic Gradle 7+ patterns
All existing tests pass without modification, ensuring backward compatibility.
🤖 Generated with [Claude Code](https://claude.com/claude-code)
Co-Authored-By: Claude <noreply@anthropic.com>
Added comprehensive test suite to verify configuration cache compatibility for all plugins with JUnit 5: Tests added: - NebulaFacetPlugin with non-test facets - NebulaFacetPlugin with custom test facets - NebulaIntegTestPlugin - NebulaIntegTestStandalonePlugin - Multiple facets support - Test facet lifecycle configuration (included/excluded from check) All tests verify that: 1. Configuration cache is properly stored on first build 2. Configuration cache is reused on subsequent builds 3. Tasks execute correctly with cached configuration The test suite uses JUnit 5 (Jupiter) with a custom writeJUnit5Test helper to generate appropriate test files. All 67 tests pass including the new configuration cache tests. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
Added 20 new configuration cache tests across 4 test classes that can run in parallel for better test performance: **ConfigurationCacheAdvancedSpec** (5 tests): - Nested facet inheritance (smokeTest extends functionalTest extends test) - Multiple test facets with mixed check lifecycle inclusion - Facets with external dependencies (Mockito) - Parallel execution of multiple facets - Custom source directories **ConfigurationCacheMultiProjectSpec** (3 tests): - Facets in multi-project builds - Cross-project facet dependencies - Parallel multi-project builds with facets **ConfigurationCacheInvalidationSpec** (6 tests): - Cache invalidation when includeInCheckLifecycle changes - Cache invalidation when new facet is added - Cache invalidation when dependencies change - Cache invalidation when testTaskName changes - Cache invalidation when parentSourceSet changes - Cache reuse when only source code changes (not configuration) **ConfigurationCacheResponsiblePluginSpec** (6 tests): - NebulaResponsiblePlugin basic functionality - Combined with integTest plugin - With custom facets - With dependency lock disabled - Publishing with configuration cache - Javadoc configuration All tests use JUnit 5 exclusively and verify that: 1. Configuration cache is stored on first build 2. Configuration cache is reused on subsequent builds 3. Cache is invalidated when configuration changes 4. Cache is reused when only source code changes Test Results: 87/87 tests passing (67 original + 20 new) 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
rpalcolea
force-pushed
the
improve-provider-api-configuration-avoidance
branch
from
62fd2eb to
9ae7856
Compare
wakingrufus
approved these changes
Dec 1, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit improves Gradle configuration avoidance and prepares the plugin for configuration cache support by implementing the Provider API throughout the codebase.
Key improvements:
Converted properties to use Provider API:
FacetDefinition.parentSourceSetnow usesProperty<String>TestFacetDefinition.testTaskNamenow usesProperty<String>TestFacetDefinition.includeInCheckLifecyclenow usesProperty<Boolean>@Injectconstructors withObjectFactoryparametersUpdated object creation:
FacetDefinitionandTestFacetDefinitioninstances now created viaproject.objects.newInstance()for proper dependency injectionAdd configuration cache tests