fix deprecated ServiceLocatorAwareInterface warning#3
Open
bvarent wants to merge 6 commits intoneeckeloo:masterfrom
Open
fix deprecated ServiceLocatorAwareInterface warning#3bvarent wants to merge 6 commits intoneeckeloo:masterfrom
bvarent wants to merge 6 commits intoneeckeloo:masterfrom
Conversation
added 3 commits
May 31, 2016 12:34
by having the PluginManager factories inject the ServiceLocator themselves resolves neeckeloo#2
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixed the deprecated ServiceLocatorAwareInterface warning by having the PluginManager factories inject the ServiceLocator themselves.
resolves #2
I found it hard to come up with a test for the issue. The deprecation warning is/was thrown when ZF2's
ServiceManagerapplies theServiceLocatorAwareInitializerto thePluginManagerscreated by MonoLog's*PluginManagerFactorys, and the initializer finds out that aServiceLocatorwas not yet set.