Fix: No ZIP/PLZ-code for Accompanying details #344#348
Merged
need4deed merged 3 commits intoneed4deed-org:developfrom Apr 24, 2026
Merged
Conversation
Fix: No ZIP/PLZ-code for Accompanying details need4deed-org#344
nadavosa
requested changes
Apr 20, 2026
Collaborator
nadavosa
left a comment
nadavosa
left a comment
There was a problem hiding this comment.
Same pattern issue as #346 — helpers.ts hardcodes the initial value to "" instead of reading from details:
// current (bug — existing postcode never loaded)
appointmentPostcode: "",
// should be
appointmentPostcode: details?.appointmentPostcode || "",Everything else (schema, display, edit) looks correct.
Fix: helpers.ts
Contributor
Author
|
Updated |
Collaborator
|
Before this gets merged, please run |
Contributor
Author
|
Everything is fine |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix: No ZIP/PLZ-code for Accompanying details #344
Description
Adds the ZIP/PLZ-code field to the Accompanying Details section on the frontend. Backend support is still needed to persist the value.
Related Issues
Closes #344
Changes
appointmentPostcodefield to the accompanying details schemaScreenshots / Demos
Checklist