feat: add schedule availability filter to opportunities dashboard#420
Merged
DarrellRoberts merged 2 commits intoneed4deed-org:developfrom Apr 30, 2026
Merged
Conversation
DarrellRoberts
requested changes
Apr 28, 2026
Collaborator
DarrellRoberts
left a comment
DarrellRoberts
left a comment
There was a problem hiding this comment.
Looks good and well implemented! Just a short note on i18n
| const { days, times, occasional } = availability; | ||
|
|
||
| const createAvailabilityGroup = <K extends keyof ScheduleFilter, T extends SelectionMap>(labelKey: K, obj: T) => ({ | ||
| label: t(`dashboard.volunteers.filters.preferredAv.${labelKey}.header`), |
Collaborator
There was a problem hiding this comment.
in the i18n jsons, can you create an opportunities equivalent and use that for consistency?
e.g.
t(`dashboard.opportunities.filters.preferredAv.${labelKey}.header`)| const createAvailabilityGroup = <K extends keyof ScheduleFilter, T extends SelectionMap>(labelKey: K, obj: T) => ({ | ||
| label: t(`dashboard.volunteers.filters.preferredAv.${labelKey}.header`), | ||
| items: Object.keys(obj).map((key) => ({ | ||
| label: t(`dashboard.volunteers.filters.preferredAv.${labelKey}.${key}`), |
Collaborator
Author
There was a problem hiding this comment.
Good call, added dashboard.opportunities.filters.preferredAv.* to both EN and DE translation files, and updated createAvailabilityFilterItems to use the opportunities-specific keys instead of borrowing from volunteers. Ty for reviewing Darrell
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #405
The opportunities dashboard had no way to filter by volunteer availability/schedule. This adds the same schedule filter that already exists on the volunteers dashboard.
The ScheduleFilter type (days / times / occasional) was moved to the shared common/CardsFilter/types.ts so both dashboards can reference it without duplication. The volunteer filter now imports Availability from that shared location. Opportunity filter constants, serializer, deserializer, filter-item builder, and FiltersContent were all extended to include the availability accordion.
Changes: