Skip to content

[Snyk] Upgrade react-scripts from 2.1.3 to 2.1.8#559

Open
nejidevelops wants to merge 1 commit intomasterfrom
snyk-upgrade-d8e7708ed59a68db892c44672e5a3bbc
Open

[Snyk] Upgrade react-scripts from 2.1.3 to 2.1.8#559
nejidevelops wants to merge 1 commit intomasterfrom
snyk-upgrade-d8e7708ed59a68db892c44672e5a3bbc

Conversation

@nejidevelops
Copy link
Owner

snyk-top-banner

Snyk has created this PR to upgrade react-scripts from 2.1.3 to 2.1.8.

ℹ️ Keep your dependencies up-to-date. This makes it easier to fix existing vulnerabilities and to more quickly identify and fix newly disclosed vulnerabilities when they affect your project.


  • The recommended version is 5 versions ahead of your current version.

  • The recommended version was released 7 years ago.

Issues fixed by the recommended upgrade:

Issue Score Exploit Maturity
critical severity Incomplete List of Disallowed Inputs
SNYK-JS-BABELTRAVERSE-5962462
786 Proof of Concept
high severity Regular Expression Denial of Service (ReDoS)
SNYK-JS-SSRI-1246392
786 Proof of Concept
Release notes
Package name: react-scripts
  • 2.1.8 - 2019-03-07
  • 2.1.7 - 2019-03-07
  • 2.1.6 - 2019-03-06
  • 2.1.5 - 2019-02-11
  • 2.1.4 - 2019-02-10
  • 2.1.3 - 2019-01-04
from react-scripts GitHub release notes

Important

  • Check the changes in this PR to ensure they won't cause issues with your project.
  • This PR was automatically created by Snyk using the credentials of a real user.
  • Max score is 1000. Note that the real score may have changed since the PR was raised.

Note: You are seeing this because you or someone else with access to this repository has authorized Snyk to open upgrade PRs.

For more information:

Snyk has created this PR to upgrade react-scripts from 2.1.3 to 2.1.8.

See this package in npm:
react-scripts

See this project in Snyk:
https://app.snyk.io/org/mohammadnewton/project/22edd24b-54ca-4e0b-a30b-3a42f37de584?utm_source=github&utm_medium=referral&page=upgrade-pr
@gemini-code-assist
Copy link

Summary of Changes

Hello @nejidevelops, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request, automatically generated by Snyk, aims to enhance project security by updating the react-scripts dependency. While the PR description indicates an upgrade from 2.1.3 to 2.1.8 to resolve critical and high-severity vulnerabilities, the actual code change in package.json downgrades react-scripts from 5.0.1 to 2.1.8. This discrepancy is crucial and requires careful review to ensure the intended security improvements are achieved without introducing new issues or breaking existing functionality due to an older dependency version.

Highlights

  • Automated Security PR: This pull request was automatically generated by Snyk to address security vulnerabilities.
  • Dependency Version Discrepancy: The PR title and description state an upgrade of react-scripts from 2.1.3 to 2.1.8. However, the actual patch changes the react-scripts dependency from 5.0.1 to 2.1.8 in package.json, which is a significant downgrade.
  • Security Vulnerabilities Addressed (Intended): The PR aims to fix two security vulnerabilities: a critical 'Incomplete List of Disallowed Inputs' (SNYK-JS-BABELTRAVERSE-5962462) and a high-severity 'Regular Expression Denial of Service (ReDoS)' (SNYK-JS-SSRI-1246392).
  • Potential Impact of Downgrade: The actual change to react-scripts version 2.1.8 from 5.0.1 could introduce compatibility issues or reintroduce bugs, as version 2.1.8 was released approximately 7 years ago, while 5.0.1 is a much more recent version.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request, automatically generated by Snyk, proposes a dependency update for react-scripts. However, the change is a significant downgrade from version 5.0.1 to 2.1.8, not an upgrade as the PR title and description suggest. This downgrade will cause the application to break due to incompatibility between the old react-scripts version and the project's React 18 dependency. It appears the Snyk tool operated on outdated or incorrect information about the project's dependencies. The proposed change should be rejected.

"react": "^18.1.0",
"react-dom": "^18.1.0",
"react-scripts": "5.0.1",
"react-scripts": "2.1.8",

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

critical

This change incorrectly downgrades react-scripts from version 5.0.1 to 2.1.8. This is a major version downgrade that will break the application, as react-scripts@2.1.8 is incompatible with React 18, which is used in this project ("react": "^18.1.0").

While the goal of fixing security vulnerabilities is important, this change is not the correct way to do it and should be reverted. The Snyk tool seems to have based this change on incorrect information about the current version of react-scripts.

Suggested change
"react-scripts": "2.1.8",
"react-scripts": "5.0.1",

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants