[Snyk] Upgrade react-scripts from 2.1.3 to 2.1.8#567
[Snyk] Upgrade react-scripts from 2.1.3 to 2.1.8#567nejidevelops wants to merge 1 commit intomasterfrom
Conversation
Snyk has created this PR to upgrade react-scripts from 2.1.3 to 2.1.8. See this package in npm: react-scripts See this project in Snyk: https://app.snyk.io/org/newtonombese1/project/0dbeb3c7-0f2b-4df0-ac5a-fd0108caddf4?utm_source=github&utm_medium=referral&page=upgrade-pr
Summary of ChangesHello @nejidevelops, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request, automatically generated by Snyk, modifies the Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Changelog
Activity
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request, automatically generated by Snyk, proposes a downgrade of the react-scripts package from version 5.0.1 to 2.1.8. This is a critical issue as it represents a major version downgrade that is incompatible with the project's React version (v18) and will likely break the application. The PR description is misleading as it describes an upgrade from a much older version. I have added a comment to reject this change and keep the current version.
| "react": "^18.1.0", | ||
| "react-dom": "^18.1.0", | ||
| "react-scripts": "5.0.1", | ||
| "react-scripts": "2.1.8", |
There was a problem hiding this comment.
This change introduces a significant downgrade of react-scripts from version 5.0.1 to 2.1.8. This is a major version downgrade and is highly likely to break the application, as react-scripts@2.x is not compatible with React 18, which is used in this project ("react": "^18.1.0").
The PR title and description state this is an upgrade from 2.1.3 to 2.1.8, which is inconsistent with the actual change in the code. It seems the Snyk scan was based on an outdated dependency tree.
Downgrading to such an old version will likely reintroduce many security vulnerabilities and bugs that have been fixed in newer versions. It is strongly recommended to reject this change. The dependency should remain at 5.0.1 or be upgraded to a newer version if available.
| "react-scripts": "2.1.8", | |
| "react-scripts": "5.0.1", |
Snyk has created this PR to upgrade react-scripts from 2.1.3 to 2.1.8.
ℹ️ Keep your dependencies up-to-date. This makes it easier to fix existing vulnerabilities and to more quickly identify and fix newly disclosed vulnerabilities when they affect your project.
The recommended version is 5 versions ahead of your current version.
The recommended version was released 7 years ago.
Issues fixed by the recommended upgrade:
SNYK-JS-BABELTRAVERSE-5962462
SNYK-JS-SSRI-1246392
Release notes
Package name: react-scripts
-
2.1.8 - 2019-03-07
-
2.1.7 - 2019-03-07
-
2.1.6 - 2019-03-06
-
2.1.5 - 2019-02-11
-
2.1.4 - 2019-02-10
-
2.1.3 - 2019-01-04
from react-scripts GitHub release notesImportant
Note: You are seeing this because you or someone else with access to this repository has authorized Snyk to open upgrade PRs.
For more information: