Skip to content

Ensure proposed block by cn #3832

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 2 commits into
base: master
Choose a base branch
from
Draft

Ensure proposed block by cn #3832

wants to merge 2 commits into from
+14 −8

Conversation

@shargon
Copy link
Member

@shargon shargon commented Mar 13, 2025 •
edited
Loading

Description

Part of #3802
Require #3802

Type of change

  • Optimization (the change is only an optimization)
  • Style (the change is only a code style for better maintenance or standard purpose)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

  • Test A
  • Test B

Test Configuration:

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@shargon shargon added the Blocked This issue can't be worked at the moment label Mar 13, 2025
@shargon shargon requested a review from superboyiii March 13, 2025 13:43
roman-khimov
roman-khimov reviewed Mar 13, 2025
View reviewed changes
src/Plugins/DBFTPlugin/Consensus/ConsensusService.OnMessage.cs
for (int i = 0; i < context.CommitPayloads.Length; i++)
var block = context.EnsureHeader();

if (!StorageItem.IsSerializable(TrimmedBlock.Create(block.Header, message.TransactionHashes)))
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Trimmed blocks is just a header + transaction hashes, how can be unserializable (if not OOM)?

Full block is a header + transactions, but transactions are verified and if we need an serializability checks for them it should be done during verification.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is serialized by p2p, it's a different method with different limits, but here we ensure that is also serializable for the vm

vncoelho
vncoelho reviewed Mar 17, 2025
View reviewed changes
Copy link
Member

@vncoelho vncoelho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The idea looks good to me

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vncoelho vncoelho vncoelho left review comments

@roman-khimov roman-khimov roman-khimov left review comments

@superboyiii superboyiii Awaiting requested review from superboyiii

At least 2 approving reviews are required to merge this pull request.

Assignees

No one assigned

Labels

Blocked This issue can't be worked at the moment

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@shargon @vncoelho @roman-khimov