refactor: [draft][rfc] mrack session + host as context holder#246
Draft
pvoborni wants to merge 4 commits intoneoave:mainfrom
Draft
refactor: [draft][rfc] mrack session + host as context holder#246pvoborni wants to merge 4 commits intoneoave:mainfrom
pvoborni wants to merge 4 commits intoneoave:mainfrom
Conversation
To replace GlobalContext so that mrack run can be isolated without using global variables. Thus more unit testable and potentially usable in parallel. Signed-off-by: Petr Vobornik <pvoborni@redhat.com>
Signed-off-by: Petr Vobornik <pvoborni@redhat.com>
Signed-off-by: Petr Vobornik <pvoborni@redhat.com>
Let's allow sesion to have various transformers and providers. Signed-off-by: Petr Vobornik <pvoborni@redhat.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is currently more like an idea/RFC (request-for-comments). There is a lot of stuff missing, opening early to get feedback if it is a good idea.
The idea behind this is to not use global objects and rather pass a session object which would contain whole context (config, provisioning config, metadata, database, initialized providers). Adding the session to other objects (host, providers, transformers, outputs, actions).
I'd also unitize
Hostobject for carrying a provisioning context. I.e. it would be initialized e.g. in following way:Also the PR adds more python typing - helps with the refactoring to find areas which has type mismatch.
The envisioned benefits/purposes are: