Support enum extensions in-source with JST#304
Draft
lukebemish wants to merge 1 commit intoneoforged:NG_7.1from
Draft
Support enum extensions in-source with JST#304lukebemish wants to merge 1 commit intoneoforged:NG_7.1from
lukebemish wants to merge 1 commit intoneoforged:NG_7.1from
Conversation
Waiting on a neo version to write tests against
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Goes with neoforged/JavaSourceTransformer#62 and company.
Currently, tests like exist for interface injections cannot be easily written for this; none of them will pass until a neo version with neoforged/FancyModLoader#412 is published, since source enum extensions require some runtime support as well. Other than those missing tests, this PR is ready for review