changes for test rail reporting #7
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
afathonih
requested changes
Dec 16, 2022
Collaborator
afathonih
left a comment
afathonih
left a comment
There was a problem hiding this comment.
Once we extract that custom_test_device string, we are good with this PR.
| } | ||
|
|
||
| String deviceName = System.getProperty("testRail.device"); | ||
| System.out.println("DEVICE IS"+deviceName); |
Collaborator
There was a problem hiding this comment.
Add colon, space and makes it sentence case to look nice.
| if (deviceName != null) { | ||
| try { | ||
| args.primaryDevice = deviceName; | ||
| } catch(NumberFormatException ex) { |
Collaborator
There was a problem hiding this comment.
Why do we need this try-catch? Is it converting it to number?
| new String(comment.toString().getBytes(StandardCharsets.ISO_8859_1), StandardCharsets.UTF_8)); | ||
| body.put("elapsed", elapsed); | ||
|
|
||
| body.put("custom_test_device", 999);//comment added |
Collaborator
There was a problem hiding this comment.
Since this is hard-coded field name, let's move it as constant where it's easy to find. Or makes it as another argument with default value.
| body.put("comment", new String(comment.toString().getBytes(StandardCharsets.ISO_8859_1), | ||
| StandardCharsets.UTF_8)); | ||
| body.put("elapsed", elapsed); | ||
| body.put("custom_test_device",999); |
Collaborator
There was a problem hiding this comment.
Same as above:
Since this is hard-coded field name, let's move it as constant where it's easy to find. Or makes it as another argument with default value.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@neofreko Added changes - To show the devices used for test execution via automation