Skip to content

BUGFIX: Ad id attribute to form fields #86

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
jonnitto wants to merge 2 commits into
base: main
Choose a base branch
from
Open

BUGFIX: Ad id attribute to form fields #86

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
68bb8ff
TASK: Better class rendering and fix typo in label renderer
jonnitto Aug 29, 2023
a7f1655
BUGFIX: Add id to form elements
jonnitto Aug 29, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions Resources/Private/Fusion/Prototypes/Checkbox.fusion
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,7 @@ prototype(Neos.Fusion.Form:Checkbox) < prototype(Neos.Fusion.Form:Component.Fie

renderer = afx`
<input
id={field.getName()}
type="checkbox"
name={field.getName()}
value={field.getTargetValueStringified()}
Expand Down
1 change: 1 addition & 0 deletions Resources/Private/Fusion/Prototypes/Date.fusion
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@ prototype(Neos.Fusion.Form:Date) < prototype(Neos.Fusion.Form:Component.Field)

renderer = afx`
<input
id={field.getName()}
name={field.getName()}
value={field.getCurrentValue() || field.getTargetValue()}
value.@process.format={Type.instance(value, 'DateTime') ? Date.format(value, 'Y-m-d') : value}
Expand Down
4 changes: 2 additions & 2 deletions Resources/Private/Fusion/Prototypes/FieldContainer.fusion
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,8 +28,8 @@ prototype(Neos.Fusion.Form:FieldContainer) < prototype(Neos.Fusion.Form:Compone
errorRenderer = 'Neos.Fusion.Form:ErrorRenderer'

renderer = afx`
<div class={props.class + (field.hasErrors() ? ' ' + props.errorClass : '')} {...props.attributes} >
<Neos.Fusion:Renderer @if.hasErrors={props.label} type={props.labelRenderer} element.for={field.getName()} element.label={props.label} />
<div class={[props.class, field.hasErrors() ? props.errorClass : null]} {...props.attributes} >
<Neos.Fusion:Renderer @if.hasLabel={props.label} type={props.labelRenderer} element.for={field.getName()} element.label={props.label} />
{props.content}
<Neos.Fusion:Renderer @if.hasErrors={field.hasErrors()} type={props.errorRenderer} element.result={field.getResult()} />
</div>
Expand Down
1 change: 1 addition & 0 deletions Resources/Private/Fusion/Prototypes/Input.fusion
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@ prototype(Neos.Fusion.Form:Input) < prototype(Neos.Fusion.Form:Component.Field)

renderer = afx`
<input
id={field.getName()}
name={field.getName()}
value={field.getCurrentValueStringified() || field.getTargetValueStringified()}
{...props.attributes}
Expand Down
1 change: 1 addition & 0 deletions Resources/Private/Fusion/Prototypes/Radio.fusion
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,7 @@ prototype(Neos.Fusion.Form:Radio) < prototype(Neos.Fusion.Form:Component.Field)

renderer = afx`
<input
id={field.getName() + '-' + field.getTargetValueStringified()}
type="radio"
name={field.getName()}
value={field.getTargetValueStringified()}
Expand Down
1 change: 1 addition & 0 deletions Resources/Private/Fusion/Prototypes/Select.fusion
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@ prototype(Neos.Fusion.Form:Select) < prototype(Neos.Fusion.Form:Component.Field

renderer = afx`
<select
id={field.getName()}
name={field.getName()}
multiple={field.isMultiple()}
{...props.attributes}
Expand Down
1 change: 1 addition & 0 deletions Resources/Private/Fusion/Prototypes/Textarea.fusion
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@ prototype(Neos.Fusion.Form:Textarea) < prototype(Neos.Fusion.Form:Component.Fie

renderer = afx`
<textarea
id={field.getName()}
name={field.getName()}
{...props.attributes}
>
Expand Down
4 changes: 3 additions & 1 deletion Resources/Private/Fusion/Prototypes/Upload.fusion
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,10 +5,12 @@ prototype(Neos.Fusion.Form:Upload) < prototype(Neos.Fusion.Form:Component.Field
renderer = afx`
<input
@if.has={Type.instance(field.getCurrentValue(), 'Neos\Flow\ResourceManagement\PersistentResource')}
type="hidden" name={field.getName() + '[originallySubmittedResource][__identity]'}
type="hidden"
name={field.getName() + '[originallySubmittedResource][__identity]'}
value={field.getCurrentValueStringified()}
/>
<input
id={field.getName()}
name={field.getName()}
{...props.attributes}
/>
Expand Down