Skip to content

WIP: Feature: Fast forward content streams during rebase (Made non breaking)#5772

Draft
mhsdesign wants to merge 7 commits into9.2from
feature/fast-forward-content-streams-during-rebase
Draft

WIP: Feature: Fast forward content streams during rebase (Made non breaking)#5772
mhsdesign wants to merge 7 commits into9.2from
feature/fast-forward-content-streams-during-rebase

Conversation

@mhsdesign
Copy link
Copy Markdown
Member

depends on #5735
fundament later for #5771

as elaborated here #5264 (comment)
there is a dilemma to be solved. As we didn't put the fast forward event into the Neos betas at that time, half a year before the release we now have to find a way to implement fast forwarding non breaking with the events we have.
My primary goal was to keep the WorkspaceWasRebased event as is meaning that we require the previous content stream id and a new content stream id. That is achieved internally by just moving the internal pointer from old to new. But moving a content stream like this now looks very weird on the events as one event affects now the outcome of two streams which is not the intention.

Maybe the outcome is that we do still want new events and be a little breaking for 9.2, i could for example for catchup hooks and simple projections imagine an marker interface like WorkspaceNewContentInterface which can simply implemented by the WorkspaceWasRebased event as well as a WorkspaceWasForwarded event to denote that any data build up sofar must be reevaluated.

Upgrade instructions

Review instructions

Checklist

  • Code follows the PSR-2 coding style
  • Tests have been created, run and adjusted as needed
  • The PR is created against the correct branch:
    • If it's a bugfix, use the lowest maintained branch which has the bug
    • If it's a non-breaking feature, use the branch of the next version (might be either minor or major)
    • If it's a breaking feature it should typically go into the next major version
  • Reviewer - PR Title is brief but complete and starts with FEATURE|TASK|BUGFIX
  • Reviewer - The first section explains the change briefly for change-logs
  • Reviewer - Breaking Changes are marked with !!! and have upgrade-instructions

Following features are implemented:

01-RootNodeCreation
02-NodeCreation
03-NodeVariation
04-NodeModification
05-NodeReferencing
Following features are implemented:

06-NodeDisabling
07-NodeRemoval
08-NodeMove
09-NodeRenaming
11-NodeTypeChange
…ViolationDetectionTrait`) 2

For internal testing
@github-actions github-actions bot added the 9.2 label Apr 3, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant