WIP: Feature: Fast forward content streams during rebase (Made non breaking)#5772
Draft
WIP: Feature: Fast forward content streams during rebase (Made non breaking)#5772
Conversation
Following features are implemented: 01-RootNodeCreation 02-NodeCreation 03-NodeVariation 04-NodeModification 05-NodeReferencing
Following features are implemented: 06-NodeDisabling 07-NodeRemoval 08-NodeMove 09-NodeRenaming 11-NodeTypeChange
…ViolationDetector`)
…ViolationDetectionTrait`) 2 For internal testing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
depends on #5735
fundament later for #5771
as elaborated here #5264 (comment)
there is a dilemma to be solved. As we didn't put the fast forward event into the Neos betas at that time, half a year before the release we now have to find a way to implement fast forwarding non breaking with the events we have.
My primary goal was to keep the
WorkspaceWasRebasedevent as is meaning that we require the previous content stream id and a new content stream id. That is achieved internally by just moving the internal pointer from old to new. But moving a content stream like this now looks very weird on the events as one event affects now the outcome of two streams which is not the intention.Maybe the outcome is that we do still want new events and be a little breaking for 9.2, i could for example for catchup hooks and simple projections imagine an marker interface like
WorkspaceNewContentInterfacewhich can simply implemented by theWorkspaceWasRebasedevent as well as aWorkspaceWasForwardedevent to denote that any data build up sofar must be reevaluated.Upgrade instructions
Review instructions
Checklist
FEATURE|TASK|BUGFIX!!!and have upgrade-instructions