TASK: Adjust to ViewInterface change in Neos.Flow and Neos.Neos#3758
Merged
TASK: Adjust to ViewInterface change in Neos.Flow and Neos.Neos#3758
ViewInterface change in Neos.Flow and Neos.Neos#3758Conversation
grebaldi
approved these changes
Apr 17, 2024
Contributor
grebaldi
left a comment
grebaldi
left a comment
There was a problem hiding this comment.
Hi @mhsdesign,
I have been testing this change in conjunction with neos/neos-development-collection#4856, thus can confirm that it works.
Code LGTM 👍
Thanks for taking care of adjusting everything over the span of 3 repositories 🙇
mhsdesign
force-pushed
the
task/adjustToViewInterfaceChange
branch
from
a7b193d to
3618537
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
see neos/flow-development-collection#3286
see neos/neos-development-collection#4856
e2e passes locally :)
What I did
How I did it
How to verify it