Contributing guide update and Community guide#796
Contributing guide update and Community guide#796radoslawc wants to merge 9 commits intonephio-project:mainfrom
Conversation
Co-authored-by: Rahul Jadhav <nyrahul@gmail.com>
Co-authored-by: Rahul Jadhav <nyrahul@gmail.com>
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: nyrahul The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
|
||
| ### Requirements | ||
|
|
||
| - Ensure affiliation is up to date in [openprofile.dev]. |
There was a problem hiding this comment.
Is this a missing link? "[openprofile.dev]"
There was a problem hiding this comment.
Links are defined at the bottom of doc: https://github.com/radoslawc/nephio/blob/2f99de696abb492386973cdbd9441799d85c9385/COMMUNITY.md?plain=1#L107
| - Filing or commenting on issues on GitHub | ||
| - Contributing to SIG, subproject, or community discussions (meetings, | ||
| Slack, mailing list) | ||
| - Have read the [contributor guide] |
There was a problem hiding this comment.
Should "[contributor guide]" be a link?
There was a problem hiding this comment.
You're right! Fixed
| - Code is well tested | ||
| - Tests consistently pass | ||
| - Addresses bugs or issues discovered after code is accepted | ||
| - Members can do `/lgtm` on all PRs. |
There was a problem hiding this comment.
I don't think this is the case now.
There was a problem hiding this comment.
LGTM? As far as I know should be on every repository, 'approve' is more strict.
|
We probably need to review these guides at SIG Release |
Co-authored-by: Liam Fallon <35595825+liamfallon@users.noreply.github.com>
Co-authored-by: Liam Fallon <35595825+liamfallon@users.noreply.github.com>
Co-authored-by: Liam Fallon <35595825+liamfallon@users.noreply.github.com>
Yes, that's what I'm hoping for |
…uide Kudos to Rado for the material nephio-project/nephio#796 Signed-off-by: Timo Perälä <timo.perala@nokia.com> Co-authored-by: Radoslaw Chmiel <radoslawc@gmail.com>
|
3 participants
Here's the update for contributing guide that adds the Nephio specific items like Prow. I've also added community guide that describes roles and
graduationprocess. Please note that this is just a work in progress document and all changes, proposals etc are more than welcome.