Skip to content

Removes modelmesh-enabled label #291

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
QuanMPhm wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Removes modelmesh-enabled label #291

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion src/coldfront_plugin_cloud/openshift.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,6 @@

PROJECT_DEFAULT_LABELS = {
"opendatahub.io/dashboard": "true",
"modelmesh-enabled": "true",
"nerc.mghpcc.org/allow-unencrypted-routes": "true",
"nerc.mghpcc.org/project": "true",
}
Comment on lines 31 to 35
Copy link

Copilot AI Feb 12, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removing modelmesh-enabled from PROJECT_DEFAULT_LABELS prevents it from being added to new namespaces, but existing namespaces will keep the label because validate_allocations' sync_openshift_project_labels only adds missing labels and never removes labels that are no longer defaults. If the goal is to unblock model-serving selection for existing RHOAI namespaces too, consider explicitly deleting modelmesh-enabled during validation/migration when --apply is used (without removing other user-managed labels).

Copilot uses AI. Check for mistakes.
Copy link
Collaborator

@knikolla knikolla Feb 12, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@IsaiahStapleton do you want modelmesh-enabled: True to be removed from all existing namespaces?

Copy link

@IsaiahStapleton IsaiahStapleton Feb 12, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Milstein What do you think? I think no, because the user can already change it themselves so it might be disruptive to change all of them now like that.

Copy link
Collaborator

@knikolla knikolla Feb 12, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@IsaiahStapleton so you just want the label to not be added for new namespaces going forward?

Copy link

@IsaiahStapleton IsaiahStapleton Feb 13, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@knikolla I think that's what would be best yes. Not sure what others think.

Expand Down