Feature: Add ncore-v4 support#897
Open
michael-shelley wants to merge 22 commits intonerfstudio-project:mainfrom
Open
Feature: Add ncore-v4 support#897michael-shelley wants to merge 22 commits intonerfstudio-project:mainfrom
michael-shelley wants to merge 22 commits intonerfstudio-project:mainfrom
Conversation
zgojcic
reviewed
Mar 17, 2026
zgojcic
reviewed
Mar 17, 2026
Collaborator
|
LGTM. i dont have comments or concerns on my side. |
Collaborator
|
[++ @nvibd] |
michael-shelley
force-pushed
the
mshelley/ncore-v4-support
branch
from
ea12111 to
876b0c4
Compare
nvibd
reviewed
Mar 18, 2026
janickm
requested changes
Mar 23, 2026
Collaborator
janickm
left a comment
janickm
left a comment
There was a problem hiding this comment.
[pushed some cleanups, but still need to fully test on my end still all the use-cases we want to support + check on performance also]
janickm
reviewed
Mar 24, 2026
janickm
approved these changes
Mar 24, 2026
Add scipy to project.toml
…-UT use case would fail
Move the inline NCore v4 dataset instructions from README.md to a dedicated Sphinx docs page (docs/source/examples/ncore.rst), matching the existing pattern used by the COLMAP example. The README now links to the docs page instead of duplicating the content. Also adds a note about explicitly specifying camera/lidar sensor IDs via --ncore-camera-ids / --ncore-lidar-ids when a sequence contains multiple sensors.
janickm
force-pushed
the
mshelley/ncore-v4-support
branch
from
3a01be6 to
6eb0fb9
Compare
Collaborator
|
[pushed quality fixes correcting scene scales + fixed merge conflicts/rebased] |
…detected & add normalization option.
wilsonCernWq
approved these changes
Mar 30, 2026
liruilong940607
approved these changes
Mar 30, 2026
Collaborator
|
LGTM! Lets maybe squash the commits before merge |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds an example that imports an ncore v4 dataset, similar to the colmap example.