Skip to content

[NV] Add external distortion wrappers and tests#906

Merged
frtrudel merged 5 commits intomainfrom
nv/add-ext-dist-tests
Mar 25, 2026
Merged

[NV] Add external distortion wrappers and tests#906
frtrudel merged 5 commits intomainfrom
nv/add-ext-dist-tests

Conversation

@frtrudel
Copy link
Copy Markdown
Collaborator

@frtrudel frtrudel commented Mar 23, 2026

Summary

Add external distortion model wrappers and tests, enabling pluggable distortion models via a public ABC interface.

Changes

New modules

  • gsplat/cuda/_torch_external_distortion.py — pure PyTorch reference implementation for external distortion
  • gsplat/cuda/csrc/ExternalDistortionWrappers.cu — CUDA external distortion wrappers
  • gsplat/cuda/include/ExternalDistortionWrappers.h — header for CUDA wrappers
  • tests/test_external_distortion.py — tests for external distortion models

API

  • Expose ExternalDistortionModelParameters as an ABC in gsplat/__init__.py for easier client-side integration
  • Update rendering.py and _wrapper.py to support external distortion passthrough

Other

  • Add copyright headers to new files (scoped to NV)

Test plan

  • ./tests/run_tests.sh --3dgut tests/test_external_distortion.py — external distortion model tests

@vince-brisebois vince-brisebois marked this pull request as ready for review March 25, 2026 19:41
@frtrudel frtrudel merged commit e60d0e3 into main Mar 25, 2026
2 checks passed
@frtrudel frtrudel deleted the nv/add-ext-dist-tests branch March 25, 2026 19:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants