[NV] Add external distortion wrappers and tests#906
Merged
Conversation
vince-brisebois
approved these changes
Mar 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add external distortion model wrappers and tests, enabling pluggable distortion models via a public ABC interface.
Changes
New modules
gsplat/cuda/_torch_external_distortion.py— pure PyTorch reference implementation for external distortiongsplat/cuda/csrc/ExternalDistortionWrappers.cu— CUDA external distortion wrappersgsplat/cuda/include/ExternalDistortionWrappers.h— header for CUDA wrapperstests/test_external_distortion.py— tests for external distortion modelsAPI
ExternalDistortionModelParametersas an ABC ingsplat/__init__.pyfor easier client-side integrationrendering.pyand_wrapper.pyto support external distortion passthroughOther
Test plan
./tests/run_tests.sh --3dgut tests/test_external_distortion.py— external distortion model tests