replaced chain with direct function call for lodash compatibility#25
Open
CallidusAsinus wants to merge 2 commits intonervetattoo:masterfrom
Open
replaced chain with direct function call for lodash compatibility#25CallidusAsinus wants to merge 2 commits intonervetattoo:masterfrom
CallidusAsinus wants to merge 2 commits intonervetattoo:masterfrom
Conversation
|
This change is also needed if underscore is used as a ES6 module:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is my second attempt at a pull request- apologies if it's done incorrectly, I've never made a pull request before.
I was attempting to run this script in a project using lodash in place of underscore, and it was failing due to the differing syntax between chained function calls. lodash expects you to invoke
.valueat the end of a chain in which nothing is returned.My solution was to replace the chain with a direct invocation of
_.eachbecause the chaining appeared to be unimportant.