Open
Conversation
merge from main repo.
Daryl-L
force-pushed
the
feature/upgrade_lumos
branch
from
beb486c to
9abb302
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #387 +/- ##
=======================================
Coverage 65.48% 65.48%
=======================================
Files 6 6
Lines 226 226
Branches 48 48
=======================================
Hits 148 148
Misses 78 78 ☔ View full report in Codecov by Sentry. |
Daryl-L
force-pushed
the
feature/upgrade_lumos
branch
15 times, most recently
from
bb244d0 to
153527d
Compare
Daryl-L
force-pushed
the
feature/upgrade_lumos
branch
2 times, most recently
from
ebf7526 to
8660ce4
Compare
Daryl-L
force-pushed
the
feature/upgrade_lumos
branch
from
8660ce4 to
13f1ec1
Compare
homura
reviewed
Oct 29, 2024
| 202, 200, 125, 162, 19, 177, 84, | ||
| 182, 234, 225, 250, 79, 0, 118, | ||
| 228, 185, 55, 81, 252, 66, 178, | ||
| 228, 166, 244, 108 |
Contributor
There was a problem hiding this comment.
use the code hash instead of the type hash to make it keep the same between different devnets
|
|
||
| toIndexerScript(): IndexerScript { | ||
| return { code_hash: this.codeHash, args: this.args, hash_type: this.hashType }; | ||
| return codeHash === script.codeHash && args === script.args && hashType === script.hashType; |
Contributor
There was a problem hiding this comment.
The args might be an Ethereum checksum address, it would be more robust to compare them by serialized result
bytes.equal(codeHash, script.codeHash)
&& bytes.equal(args, script.args)
&& hashType === script.hashType
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.