Conversation
src/main/res/values/strings.xml
Outdated
| <string name="fix_permissions">Fix permissions</string> | ||
| <string name="err_kitkat_required">Android 4.4 or greater is required to use this feature.</string> | ||
| <string name="restore_finished">SMS restoration is now finished.</string> | ||
| <string name="err_kitkat_required">Android 4.4 or above is required to use this feature.</string> |
|
|
||
| <!-- Login --> | ||
| <string name="prompt_login">Login</string> | ||
| <string name="prompt_login">Log in</string> |
There was a problem hiding this comment.
sorry but i'm not in favor of this space
There was a problem hiding this comment.
"Login" is not a verb, whereas "Log in" is.
| <string name="sync_title">Sync process</string> | ||
| <string name="sync_inprogress">Sync in progress...</string> | ||
| <string name="fatal_error">Fatal error ! </string> | ||
| <string name="sync_inprogress">Sync in progress …</string> |
There was a problem hiding this comment.
those ... are not supported on android if i remember
There was a problem hiding this comment.
Ellipses are UTF-8. Works just fine.
There was a problem hiding this comment.
True, while Android lint warns you to use the character code … instead :)
There was a problem hiding this comment.
I wouldn't say wrong, just not how Android wants it to be expressed. See e.g. http://www.mysamplecode.com/2012/05/android-replace-with-ellipsis-character.html?m=1
There was a problem hiding this comment.
Well, that isn't in other Nextcloud Android resources, and it is very prone to errors in translation.
nerzhul
left a comment
nerzhul
left a comment
There was a problem hiding this comment.
thanks, you should also fix the en_US and en_GB files with the same fix ?
|
ping |
|
@nerzhul The other resources will be overwritten by the translation platform regardless. |
|
@nerzhul ACK |
3 participants
As per https://en.wiktionary.org/wiki/SMSes
The "could not read your SMSes" should possibly be a singular (?)