Node redis #2
Merged
Node redis #2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ntation - Introduced a new Redis module with dynamic configuration capabilities. - Added Redis service for managing Redis client connections. - Updated README and package.json to reflect changes in dependencies and installation instructions. - Created .editorconfig for consistent coding styles across the project.
…nsuring proper async handling
… sentinel support
Collaborator
Author
|
@BugBot run |
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
…luster mode checks
Collaborator
Author
|
@BugBot run |
There was a problem hiding this comment.
Bug: TypeScript Safety Violation in Redis Client
The cluster as unknown as RedisClusterType assertion in createRedisClient uses double casting through unknown, bypassing TypeScript's type safety. This can mask type mismatches between createCluster()'s return and RedisClusterType, potentially causing runtime errors. This approach is inconsistent with the direct casting used for RedisClientType.
packages/node-redis/lib/redis.providers.ts#L14-L15
nestjs-redis/packages/node-redis/lib/redis.providers.ts
Lines 14 to 15 in 4f75d1e
Was this report helpful? Give feedback by reacting with 👍 or 👎
…isClient function
…pository structure
…tjs-ioredis package
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
liaoliaots#562