Support frozen strings

[npezza93]

No description provided.

[mfazekas]

why was it converted to non dev dependency?

[npezza93]

Weird, no idea. hah. Reverted

[robertcheramy]

Why should frozen-string-literals be enabled in the CI?
If we want to see the warnings about frozen string literals in the CI, we should use -W:deprecated and add ruby 3.4 as a target.

I also think it is better to have command = String.new('scp ') than the complicated test about the ruby version.

[npezza93]

Why should frozen-string-literals be enabled in the CI?

To catch any other places that would fail if frozen strings were enabled. And to also catch regressions

-W:deprecated

I think this just outputs warnings. In CI we would want actual failures.

Looks like the failures are due to net-ssh not yet supporting frozen strings

[robertcheramy]

This is not a good solution to fail all tests as long as Net::SCP didn't fix its frozen string literals, because no CI test will work and we will not be able to see if a PR is OK or not. Frozen string literals will only be default in Ruby 4.0, so we have no rush and out CI will fail against ruby-head as soon as it is make default there.

I propose not to enable frozen string literals, and to modify Rakefile to warn about them:

Rake::TestTask.new do |t|
  t.ruby_opts = ['-W:deprecated']
  t.libs = ["lib", "test"]
end

This way, we can see where there is work to do, and we still can use the CI to check against all ruby versions.

[nodeg]

Any updates on this?

[morgoth]

It would be very helpful to be string-freeze safe.
In our app we enabled frozen strings by default.

Frozen string literals will only be default in Ruby 4.0, so we have no rush

Let's get ready :-)

[npezza93]

Tests are failing due to net-ssh not supporting frozen strings. I have addressed that here: net-ssh/net-ssh#958

[morgoth]

@mfazekas Looks like ready to be merged