Add correct support for SFTP V5 access bits#155
Open
DougEdey-Filescom wants to merge 2 commits intonet-ssh:masterfrom
Open
Add correct support for SFTP V5 access bits#155DougEdey-Filescom wants to merge 2 commits intonet-ssh:masterfrom
DougEdey-Filescom wants to merge 2 commits intonet-ssh:masterfrom
Conversation
Author
|
👋 @mfazekas heyo! I know there's not been any updates to Net SFTP in a while |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Current implementation of SFTP v5 is missing the
access-bitsattributeExample issue: #78 #66
Stackoverflow: https://stackoverflow.com/questions/42124883/broken-filenames-with-ruby-when-connected-to-sftp-version-5
If you find a V5 server (there's a few out there, Windows: FileCOPA) and try to connect to it and run a file listing:
You get corrupted output:
When using this specifying SFTP V4:
with the patched version of net sftp: