Skip to content

Update README.md - add link_fabric_delete_mode and edge_connections_delete_mode #377

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from
Open

Update README.md - add link_fabric_delete_mode and edge_connections_delete_mode #377

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6ba63fc
Update README.md
juburnet May 8, 2025
1ffe7eb
Update README.md for edge_connections_delete_mode
juburnet May 12, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,8 @@ The `remove` role removes state from the NDFC controller and the devices managed
Inside the [example repository](https://github.com/netascode/ansible-dc-vxlan-example) under `group_vars/ndfc` is a file called `ndfc.yaml` that contains the variables:

```yaml
# Control Parameters for 'Remove' role tasks in VXLAN EVPN fabric
# Control Parameters for 'Remove' role tasks in VXLAN EVPN, External, and ISN fabrics
edge_connections_delete_mode: false
interface_delete_mode: false
inventory_delete_mode: false
link_fabric_delete_mode: false
Expand Down Expand Up @@ -83,8 +84,10 @@ The following control variables are available in this collection.
| Variable | Description | Default Value |
| -------- | ------- | ------- |
| `force_run_all` | Force all roles in the collection to run | `false` |
| `edge_connections_delete_mode` | Remove edge connections state as part of remove role | `false` |
| `interface_delete_mode` | Remove interface state as part of the remove role | `false` |
| `inventory_delete_mode` | Remove inventory state as part of the remove role | `false` |
| `link_fabric_delete_mode` | Remove fabric link state as part of the remove role | `false` |
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this for intra fabric links and edge connections?

Copy link
Collaborator Author

@juburnet juburnet May 12, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mtarking this is for intra fabric links only. It was added in PR #194 but not updated in all locations.
It's in use in links.yml in remove role: "Manage NDFC Fabric Links" for common and isn remove tasks.

It looks like @mthurstocisco added a new variable for Edge Connections - "edge_connections_delete_mode" in PR #280 . However, it looks like we don't have that in all the docs either. I will update this PR and change the title to include Edge in the docs

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@juburnet is there usage implemented everywhere we expect across common and/or different fabric types?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Merging this PR but opened #385 to track the verification effort. @juburnet can you pick this up?

| `link_vpc_delete_mode` | Remove vpc link state as part of the remove role | `false` |
| `multisite_child_fabric_delete_mode` | Remove child fabric from MSD/MFD fabric as part of the remove role | `false` |
| `multisite_network_delete_mode` | Remove network state as part of the remove role for multisite (MSD and MFD) fabrics | `false` |
Expand Down