-
Notifications
You must be signed in to change notification settings - Fork 18
Adding support for pre-prov breakout interfaces #481
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Using jinja logic to loop through breakout_interfaces and build up breakout cli string.
Updated this check so that it defaults to false if not provided
Changed the remove role so that it includes the pre-provisioned switches and then the overridden method of the interface module will then inculde these pre-prov interfaces
Added into the code to check if the switch is unreachable to pop out any breakout interfaces for that switch as they will fail. Need to wait for the switch to poap and create the breakouts first
Updated after some testing where no breakouts are provided
mikewiebe
reviewed
Aug 1, 2025
plugins/action/common/prepare_plugins/prep_105_topology_interfaces.py
Outdated
Show resolved
Hide resolved
Updated to reverse condition
Changed boolean comparison after sanity failure
mikewiebe
reviewed
Sep 10, 2025
mikewiebe
reviewed
Sep 10, 2025
mikewiebe
reviewed
Sep 10, 2025
Don't need the when clause as it would not get triggered for pre-prov which is what we need this structure for
No need for this clause as we always need to create this list. If nothing to add it will be instantiated as an empty list
No longer needed as handled by the module now
@mikewiebe - On the call today, @peter8498 said he tested this and that it is working. |
mtarking
approved these changes
Sep 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using jinja logic to loop through breakout_interfaces and build up breakout cli string.
Related Issue(s)
No issue raised
Related Collection Role
Related Data Model Element
Proposed Changes
Added new logic based off the flag breakout.enable_during_bootstrap in the data model (already defined) to
loop through the breakout_interaces and build up the CLI string that is then passed into the inventory module
to support the breakout of pre-provisioned switches.
Using the existing breakout structure on pre-prov does not work and even if you created the trunk interface first
and breakout, it errors in both the GUI and the module.
There is a possibility of doing the CLI logic in Python, but thought it was more maintainable to it in the jinja template, but
open to reviews on this.
Need to add some explanation in the documentation of how this flag works and the way it differs and why we need it on pre-prov switches. Also once the switch has been added you cannot update or delete this config. That shoudl then be done with breakout with the flag set to false (or no included).
Test Notes
Tested with data liek this:
Cisco NDFC Version
12.2.2
Checklist