Skip to content

Fix missing peer context in group network routes tab#620

Merged
heisbrot merged 1 commit intomainfrom
fix/group-network-routes-page
Apr 23, 2026
Merged

Fix missing peer context in group network routes tab#620
heisbrot merged 1 commit intomainfrom
fix/group-network-routes-page

Conversation

@heisbrot
Copy link
Copy Markdown
Contributor

@heisbrot heisbrot commented Apr 23, 2026

Issue ticket number and link

Documentation

Select exactly one:

  • I added/updated documentation for this change
  • Documentation is not needed for this change (explain why)

Docs PR URL (required if "docs added" is checked)

Paste the PR link from https://github.com/netbirdio/docs here:

https://github.com/netbirdio/docs/pull/__

Summary by CodeRabbit

  • Style
    • Adjusted network routes table spacing for improved layout consistency in group details view.

@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented Apr 23, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: de16b581-682b-4bfe-a06e-a6dde531a4df

📥 Commits

Reviewing files that changed from the base of the PR and between e9ac1a1 and 2e8410a.

📒 Files selected for processing (2)
  • src/modules/groups/details/GroupNetworkRoutesSection.tsx
  • src/modules/route-group/NetworkRoutesTable.tsx

📝 Walkthrough

Walkthrough

The GroupNetworkRoutesSection component is now wrapped in a PeersProvider context to provision the rendered subtree, while NetworkRoutesTable's styling is updated to remove bottom margin from the DataTable.

Changes

Cohort / File(s) Summary
PeersProvider Context Wrapping
src/modules/groups/details/GroupNetworkRoutesSection.tsx
GroupDetailsTableContainer (and nested NetworkRoutesTable) now wrapped in new PeersProvider context, shifting the rendered subtree's context provisioning.
Table Styling Update
src/modules/route-group/NetworkRoutesTable.tsx
DataTable tableClassName updated from "mt-0 mb-2" to "mt-0", removing bottom margin while preserving top margin.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Poem

🐰 A hop and a wrap in context's embrace,
With PeersProvider now finding its place,
The margins align, the spacing's just right,
Organization done—the tables take flight! ✨

🚥 Pre-merge checks | ✅ 3 | ❌ 2

❌ Failed checks (2 warnings)

Check name Status Explanation Resolution
Description check ⚠️ Warning The PR description is incomplete. Required 'Issue ticket number and link' section is entirely missing, and no explanation is provided for why documentation is not needed. Add the missing issue ticket number and link, and provide a brief explanation of why documentation is not needed for this change.
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (3 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly describes the main change: wrapping the group network routes section with PeersProvider context to fix a missing peer context issue.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/group-network-routes-page

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@heisbrot heisbrot merged commit 01330e0 into main Apr 23, 2026
6 of 7 checks passed
@heisbrot heisbrot deleted the fix/group-network-routes-page branch April 23, 2026 15:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants