Skip to content

[management] Handle missing NetworkAddresses in peer network range posture check #5806

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
MichaelUray wants to merge 1 commit into
base: main
Choose a base branch
from
+11 −5
Open

[management] Handle missing NetworkAddresses in peer network range posture check #5806

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion management/server/posture/network.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,13 @@ var _ Check = (*PeerNetworkRangeCheck)(nil)

func (p *PeerNetworkRangeCheck) Check(ctx context.Context, peer nbpeer.Peer) (bool, error) {
if len(peer.Meta.NetworkAddresses) == 0 {
return false, fmt.Errorf("peer's does not contain peer network range addresses")
// No network address info available from the peer (e.g. older mobile clients).
// For "deny" action: allow the peer since we cannot confirm it IS in the denied range.
// For "allow" action: deny the peer since we cannot confirm it IS in the allowed range.
if p.Action == CheckActionDeny {
return true, nil
}
return false, nil
}

maskedPrefixes := make([]netip.Prefix, 0, len(p.Ranges))
Expand Down
8 changes: 4 additions & 4 deletions management/server/posture/network_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -73,7 +73,7 @@ func TestPeerNetworkRangeCheck_Check(t *testing.T) {
},
},
peer: nbpeer.Peer{},
wantErr: true,
wantErr: false,
isValid: false,
},
{
Expand Down Expand Up @@ -122,7 +122,7 @@ func TestPeerNetworkRangeCheck_Check(t *testing.T) {
isValid: true,
},
{
name: "Peer with no networks range in the denied range",
name: "Peer with no networks range in the denied range is allowed through",
check: PeerNetworkRangeCheck{
Action: CheckActionDeny,
Ranges: []netip.Prefix{
Expand All @@ -131,8 +131,8 @@ func TestPeerNetworkRangeCheck_Check(t *testing.T) {
},
},
peer: nbpeer.Peer{},
wantErr: true,
isValid: false,
wantErr: false,
isValid: true,
},
}

Expand Down
Loading