Skip to content

[client] Fix review issues from IPv6 overlay PR#5839

Merged
lixmal merged 1 commit intoproto-ipv6-overlayfrom
fix-ipv6-overlay-coderabbit-issues
Apr 10, 2026
Merged

[client] Fix review issues from IPv6 overlay PR#5839
lixmal merged 1 commit intoproto-ipv6-overlayfrom
fix-ipv6-overlay-coderabbit-issues

Conversation

@lixmal
Copy link
Copy Markdown
Collaborator

@lixmal lixmal commented Apr 9, 2026

Describe your changes

Address CodeRabbit review comments from #5631.

  • Anonymize AddressV6 in debug bundles, preserving the original prefix length
  • Anonymize IPv6 ULA addresses in debug bundles (the 40-bit global ID is a network fingerprint, unlike RFC 1918 IPv4 which is reused everywhere)
  • Fix data race on extraListeners in SSH server Stop() by snapshotting under mutex
  • Warn and clear IPv6 on Windows when IPv6 MTU setup fails, matching Linux/macOS behavior
  • Clear stale DNS settings from the opposite address family in NetworkManager configurator
  • Check AddPeer errors in status test setup instead of discarding them

Issue ticket number and link

Follow-up to #5631

Stack

Checklist

  • Is it a bug fix
  • Is a typo/documentation fix
  • Is a feature enhancement
  • It is a refactor
  • Created tests that fail without the change (if possible)

By submitting this pull request, you confirm that you have read and agree to the terms of the Contributor License Agreement.

Documentation

Select exactly one:

  • I added/updated documentation for this change
  • Documentation is not needed for this change (explain why)

Internal code fixes, no user-facing behavior change.

Docs PR URL (required if "docs added" is checked)

Paste the PR link from https://github.com/netbirdio/docs here:

https://github.com/netbirdio/docs/pull/__

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented Apr 9, 2026

🚥 Pre-merge checks | ✅ 2 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (2 passed)
Check name Status Explanation
Title check ✅ Passed The title '[client] Fix review issues from IPv6 overlay PR' directly references addressing CodeRabbit review comments from a related PR and is specific enough for scanning history.
Description check ✅ Passed The pull request description follows the required template structure with all essential sections completed.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix-ipv6-overlay-coderabbit-issues

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@lixmal lixmal force-pushed the fix-ipv6-overlay-coderabbit-issues branch 2 times, most recently from df8a1a6 to 0f16559 Compare April 9, 2026 13:21
@lixmal lixmal force-pushed the fix-ipv6-overlay-coderabbit-issues branch from 0f16559 to 48267fd Compare April 9, 2026 13:24
@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud Bot commented Apr 9, 2026

@lixmal lixmal merged commit 6e05a2e into proto-ipv6-overlay Apr 10, 2026
42 checks passed
@lixmal lixmal deleted the fix-ipv6-overlay-coderabbit-issues branch April 10, 2026 01:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants