Use environment libdir instead of hardcoded /lib#76
Open
nielsenb-jf wants to merge 1 commit intonetblue30:masterfrom
Open
Use environment libdir instead of hardcoded /lib#76nielsenb-jf wants to merge 1 commit intonetblue30:masterfrom
nielsenb-jf wants to merge 1 commit intonetblue30:masterfrom
Conversation
fstats is a compiled binary, therefore "archful", and should be installed in the correct lib folder on multiarch systems (e.g. $PREFIX/lib64 on x86_64), not the hardcoded $PREFIX/lib. Installing the other components previously installed directly into $PREFIX/lib does not appear to have any harmful effects so all library paths are changed to use the libdir from the environment.
rusty-snake
reviewed
Nov 8, 2024
rusty-snake
left a comment
rusty-snake
left a comment
There was a problem hiding this comment.
LGTM
For such small changes (I.e. without design discussion before putting a lot work into it) you don't need an issue in the firejail project. You can submit the PR direct.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fstats is a compiled binary, therefore "archful", and should be installed in the correct lib folder on multiarch systems (e.g. $PREFIX/lib64 on x86_64), not the hardcoded $PREFIX/lib.
Installing the other components previously installed directly into $PREFIX/lib does not appear to have any harmful effects so all library paths are changed to use the libdir from the environment.
This fixes #75.