Update add_device_type_components.py#93
Open
mostdaysarebaddays wants to merge 1 commit intonetbox-community:masterfrom
Open
Update add_device_type_components.py#93mostdaysarebaddays wants to merge 1 commit intonetbox-community:masterfrom
mostdaysarebaddays wants to merge 1 commit intonetbox-community:masterfrom
Conversation
Contributor
|
I don't think this is necessary, can you explain why you think it is? Device type is already filtered by manufacturer: the only reason for presenting manufacturer as an input is to reduce the length of the list of device types. Whilst device types don't have unique names (you can have two device types with the same name from different manufacturers), we're filtering devices by the device_type_id which is unambiguous. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update so "Devices" also filters on manufacturer, not just model