Closes #20679 - Duplicate all GraphQL hierarchy objects to separate V1 and V2 namespaces #20667
+6,527
−10
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bctiemann
changed the title
jnovinger
requested review from
a team and
jeremystretch
and removed request for
a team
bctiemann
changed the title
bctiemann
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #20679
This has been tested such that the V1 and V2 configurations work as expected as per the
GRAPHQL_DEFAULT_VERSIONsetting. A thorough review would be to look at all the field type definitions and ensure that I didn't miss anyV1suffixes or_v1module paths in thestrawberry.lazystatements.Note that enums and lookups are not namespaced, though types and filter types are.