Skip to content

Add test coverage for createBoltDeepLinkWeb function#70

Draft
Copilot wants to merge 3 commits intobolt_deeplink_hackfrom
copilot/sub-pr-63-again
Draft

Add test coverage for createBoltDeepLinkWeb function#70
Copilot wants to merge 3 commits intobolt_deeplink_hackfrom
copilot/sub-pr-63-again

Conversation

Copy link
Copy Markdown
Contributor

Copilot AI commented Jan 19, 2026

The createBoltDeepLinkWeb function lacked test coverage despite existing comprehensive tests for the similar createBoltDeepLink function.

Changes

  • Added BoltDeepLinkWebTest.kt with 15 test cases covering:
    • HTTPS URL scheme validation (https://bolt.eu/ride/ vs bolt://ride)
    • Coordinate formatting (6 decimal precision, trailing zeros, period separator)
    • URL encoding for fallback address-based format
    • Edge cases: negative coordinates, null coordinates, special characters

Implementation

Tests follow the same structure as BoltDeepLinkFormatTest.kt:

@Test
fun testBoltDeepLinkWeb_usesHttpsScheme() {
    val deepLink = viewModel.createBoltDeepLinkWeb(
        "Start", "End",
        Pair(40.758896, -73.985130),
        Pair(40.785091, -73.968285)
    )
    
    assertTrue(deepLink.startsWith("https://"))
    assertFalse(deepLink.startsWith("bolt://"))
}

The web deep link uses the same formatCoordinate() helper ensuring identical 6-decimal precision formatting across both deep link variants.


💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.

Copilot AI and others added 2 commits January 19, 2026 16:46
Co-authored-by: neteinstein <910242+neteinstein@users.noreply.github.com>
Co-authored-by: neteinstein <910242+neteinstein@users.noreply.github.com>
Copy link
Copy Markdown
Contributor Author

Copilot AI commented Jan 19, 2026

Just as a heads up, I was blocked by some firewall rules while working on your feedback. Expand below for details.

Warning

Firewall rules blocked me from connecting to one or more addresses (expand for details)

I tried to connect to the following addresses, but was blocked by firewall rules:

  • dl.google.com
    • Triggering command: /usr/lib/jvm/temurin-17-jdk-amd64/bin/java /usr/lib/jvm/temurin-17-jdk-amd64/bin/java --add-opens=java.base/java.lang=ALL-UNNAMED --add-opens=java.base/java.lang.invoke=ALL-UNNAMED --add-opens=java.base/java.util=ALL-UNNAMED --add-opens=java.prefs/java.util.prefs=ALL-UNNAMED --add-exports=jdk.compiler/com.sun.tools.javac.api=ALL-UNNAMED --add-exports=jdk.compiler/com.sun.tools.javac.util=ALL-UNNAMED --add-opens=java.base/java.util=ALL-UNNAMED --add-opens=java.prefs/java.util.prefs=ALL-UNNAMED --add-opens=java.base/java.nio.charset=ALL-UNNAMED --add-opens=java.base/java.net=ALL-UNNAMED --add-opens=java.base/java.util.concurrent.atomic=ALL-UNNAMED --add-opens=java.xml/javax.xml.namespace=ALL-UNNAMED -XX:MaxMetaspaceSize=512m -XX:&#43;HeapDumpOnOutOfMemoryError -Xmx4g -Dfile.encoding=UTF-8 -Duser.country -Duser.language=en -Duser.variant (dns block)

If you need me to access, download, or install something from one of these locations, you can either:

Copilot AI changed the title [WIP] Fix feedback on Bolt deep link implementation Add test coverage for createBoltDeepLinkWeb function Jan 19, 2026
Copilot AI requested a review from neteinstein January 19, 2026 16:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants