-
Notifications
You must be signed in to change notification settings - Fork 1
NAB-380 #28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: feature/application_management
Are you sure you want to change the base?
NAB-380 #28
Conversation
… arcs not to load - arcs which referenced data has non integer value will be displayed/represented with value 0 in edit + simulation mode
- Add global flag support for roles and improve role ID form - Enhanced role model to include a global flag. - Updated role-detail component to handle global flag changes. - Updated `@netgrif/petriflow` dependency to 2.2.1.
… arcs not to load - Improved usage of ImportUtils.isInitValueNumber to replace regex checks for initialization values.
[NAB-375] Variables with no init values referenced in arcs will cause arcs not to load
[NAB-378] Global role support
- add default values to Application - add form controls with validations to application edit dialog - add input errors, disable buttons if form has any errors
- add icon to mortgage demo model - remove mortgage service from tutorial service due to cyclic dependency - always add demo mortgage as new process to application - remove unused confirm dialog
- add unique process id validation to edit process dialog
- refactor history service - use SequenceGenerator for model ids
- fix removing wrong process
# Conflicts: # src/app/modeler/role-mode/role-detail/role-detail.component.html # src/app/modeler/role-mode/role-detail/role-detail.component.ts # src/app/modeler/services/model/model.service.ts
- fix selected process css class
- remove unused dialog - route to editor canvas on model switch to refresh views
- refactor app view and process list to tabs
- partial fix of history
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. 🗂️ Base branches to auto review (3)
Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
Description
Implements NAB-380, NAB-381, NAB-382, and partially NAB-384
There are still few todos and bugs to fix in the future.