Skip to content

Notification#30

Open
src-r-r wants to merge 5 commits intonetmackan:masterfrom
src-r-r:master
Open

Notification#30
src-r-r wants to merge 5 commits intonetmackan:masterfrom
src-r-r:master

Conversation

@src-r-r
Copy link

@src-r-r src-r-r commented Mar 16, 2015

Hi, Markus,

Great application. Hope you don't mind if I added code to include a notification.

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this still an issue?

@netmackan
Copy link
Owner

Thank you for the pull request.
I am not sure I yet understand exactly how it works.
Could you maybe write a description about what the pull request adds, ie what is the purpose and what will the notifications display etc?

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it required that the thread is woken up once every second? Is this usually how notifications work? If it where possible to have the thread instead wait for a notify when there is a change we could probably save some battery.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, Marckus. As per the official android docs (https://developer.android.com/guide/topics/ui/notifiers/notifications.html) this is the way to start a notification. I set the time for 1 second because that's usually the interval for a clock but we can make it longer for more of a "fuzzy" time if you'd like.

@src-r-r
Copy link
Author

src-r-r commented May 24, 2015

I noticed that when I was using the application a lot of times I would clock in to an activity, forget to clock out and then hours later (or even the next day o.0) find I hadn't clocked out. After I added the notification it made it easier to remember that a task was running.

@pille
Copy link

pille commented Sep 11, 2017

any progress on this issue, @netmackan?

@robinrosenstock
Copy link

Why not merge?

@netmackan
Copy link
Owner

I see a few questions that have not been answered. Maybe they are not relevant anymore but in that case you can state so and why.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants