NETOBSERV-2387: Backend tests migration#2586
NETOBSERV-2387: Backend tests migration#2586oliver-smakal wants to merge 18 commits intonetobserv:mainfrom
Conversation
This reverts commit 05de826.
…tion/NETOBSERV-2387
|
Skipping CI for Draft Pull Request. |
|
@oliver-smakal: This pull request references NETOBSERV-2387 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.22.0" version, but no target version was set. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2586 +/- ##
==========================================
- Coverage 72.65% 72.09% -0.56%
==========================================
Files 104 105 +1
Lines 10615 10851 +236
==========================================
+ Hits 7712 7823 +111
- Misses 2429 2545 +116
- Partials 474 483 +9
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
|
@oliver-smakal: This pull request references NETOBSERV-2387 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.22.0" version, but no target version was set. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
@oliver-smakal: This pull request references NETOBSERV-2387 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.22.0" version, but no target version was set. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
| @@ -0,0 +1,44 @@ | |||
| package netobserv | |||
There was a problem hiding this comment.
should we change the package name to say, may be "integration-tests" instead?
| ensureNetObservOperatorDeployed(oc, NO, NOSource, deployedUpstreamCatalogSource) | ||
| }) | ||
|
|
||
| g.It("Author:aramesha-High-64156-Verify IPFIX-exporter [Serial]", func() { |
There was a problem hiding this comment.
I am not sure if labels like [Serial] will have any meaning here. Most of the tests that deals with flowcollector resource are Serial, we could use ginkgo Ordered decorator to make tests Serial.
We should also probably evaluate what tests could run in parallel, for e.g. FlowMetrics ones perhaps?
3 participants
Description
This PR is intended to show how the e2e backend migration of tests could look like and where we can discuss more details.
Changes compare to the openshift-tests-private repo:
ginkgodirectly without wrapperBeforeSuitepossible, but we need to be carefull about not usingcompat_otp.NewCLIand similar utilities which haveg.BeforeEachcallsTODO:
Please comment, if you see any other thinks we could change.