NETOBSERV-2620: Make prometheus default true

[Amoghrd]

Description

Prometheus is enabled by default but in forms view it shows up as default false. Updated it be default true

Dependencies

n/a

Checklist

• Does the changes in PR need specific configuration or environment set up for testing?
  • if so please describe it in PR description.
• I have added thorough unit tests for the change.
• QE requirements (check 1 from the list):
  • Standard QE validation, with pre-merge tests unless stated otherwise.
  • Regression tests only (e.g. refactoring with no user-facing change).
  • No QE (e.g. trivial change with high reviewer's confidence, or per agreement with the QE team).

Summary by CodeRabbit

• Bug Fixes

  • Prometheus querier now defaults to enabled when not explicitly configured, ensuring consistent and reliable behavior across all deployment scenarios and infrastructure configurations that aligns with documented specifications.

• Documentation

  • Updated documentation to clearly specify and highlight that Prometheus querier is enabled by default.

[openshift-ci-robot]

@Amoghrd: This pull request references NETOBSERV-2620 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.22.0" version, but no target version was set.

Details

In response to this:

Description

Prometheus is enabled by default but in forms view it shows up as default false. Updated it be default true

Dependencies

n/a

Checklist

• Does the changes in PR need specific configuration or environment set up for testing?
  • if so please describe it in PR description.
• I have added thorough unit tests for the change.
• QE requirements (check 1 from the list):
• Standard QE validation, with pre-merge tests unless stated otherwise.
• Regression tests only (e.g. refactoring with no user-facing change).
• No QE (e.g. trivial change with high reviewer's confidence, or per agreement with the QE team).

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[openshift-ci]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign jpinsonneau for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details

Needs approval from an approver in each of these files:

• DOWNSTREAM_OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: c48249d6-0f62-472b-8ce1-f76b8822fc1e

📥 Commits

Reviewing files that changed from the base of the PR and between 12e06e5 and 54c6ed6.

📒 Files selected for processing (5)

• api/flowcollector/v1beta2/flowcollector_types.go
• bundle/manifests/flows.netobserv.io_flowcollectors.yaml
• config/crd/bases/flows.netobserv.io_flowcollectors.yaml
• docs/FlowCollector.md
• helm/crds/flows.netobserv.io_flowcollectors.yaml

---

📝 Walkthrough

Walkthrough

This PR adds an explicit default: true value to the PrometheusQuerier.Enable field across the Go API type definition, CRD manifests, Helm chart, and documentation to codify its default-enabled behavior.

Changes

Cohort / File(s)	Summary
Go API Definition api/flowcollector/v1beta2/flowcollector_types.go	Added //+kubebuilder:default:=true annotation to the Enable field in PrometheusQuerier struct.
CRD Manifests bundle/manifests/flows.netobserv.io_flowcollectors.yaml, config/crd/bases/flows.netobserv.io_flowcollectors.yaml, helm/crds/flows.netobserv.io_flowcollectors.yaml	Added default: true to spec.prometheus.querier.enable schema in all three CRD manifest files.
Documentation docs/FlowCollector.md	Added "Default: true" annotation in the spec.prometheus.querier.enable field description.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

🚥 Pre-merge checks | ✅ 3

✅ Passed checks (3 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title directly addresses the main change: adding default true to the Prometheus querier enable field across all configuration files and CRD manifests.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests

Warning

Tools execution failed with the following error:

Failed to run tools: 13 INTERNAL: Received RST_STREAM with code 2 (Internal server error)

---

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[Amoghrd]

/ok-to-test

[github-actions]

New images:

quay.io/netobserv/network-observability-operator:7072d69
quay.io/netobserv/network-observability-operator-bundle:v0.0.0-sha-7072d69
quay.io/netobserv/network-observability-operator-catalog:v0.0.0-sha-7072d69

They will expire in two weeks.

To deploy this build:

# Direct deployment, from operator repo
IMAGE=quay.io/netobserv/network-observability-operator:7072d69 make deploy

# Or using operator-sdk
operator-sdk run bundle quay.io/netobserv/network-observability-operator-bundle:v0.0.0-sha-7072d69

Or as a Catalog Source:

apiVersion: operators.coreos.com/v1alpha1
kind: CatalogSource
metadata:
  name: netobserv-dev
  namespace: openshift-marketplace
spec:
  sourceType: grpc
  image: quay.io/netobserv/network-observability-operator-catalog:v0.0.0-sha-7072d69
  displayName: NetObserv development catalog
  publisher: Me
  updateStrategy:
    registryPoll:
      interval: 1m

[openshift-ci-robot]

@Amoghrd: This pull request references NETOBSERV-2620 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.22.0" version, but no target version was set.

Details

In response to this:

Description

Prometheus is enabled by default but in forms view it shows up as default false. Updated it be default true

Dependencies

n/a

Checklist

• Does the changes in PR need specific configuration or environment set up for testing?
  • if so please describe it in PR description.
• I have added thorough unit tests for the change.
• QE requirements (check 1 from the list):
• Standard QE validation, with pre-merge tests unless stated otherwise.
• Regression tests only (e.g. refactoring with no user-facing change).
• No QE (e.g. trivial change with high reviewer's confidence, or per agreement with the QE team).

Summary by CodeRabbit

• Bug Fixes

• Prometheus querier now defaults to enabled when not explicitly configured, ensuring consistent and reliable behavior across all deployment scenarios and infrastructure configurations that aligns with documented specifications.

• Documentation

• Updated documentation to clearly specify and highlight that Prometheus querier is enabled by default.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 72.28%. Comparing base (12e06e5) to head (54c6ed6).
⚠️ Report is 2 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #2597      +/-   ##
==========================================
+ Coverage   72.24%   72.28%   +0.04%     
==========================================
  Files         105      105              
  Lines       10851    10851              
==========================================
+ Hits         7839     7844       +5     
+ Misses       2531     2527       -4     
+ Partials      481      480       -1     

Flag	Coverage Δ
unittests	72.28% <ø> (+0.04%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines	Coverage Δ
api/flowcollector/v1beta2/flowcollector_types.go	100.00% <ø> (ø)

... and 2 files with indirect coverage changes

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.