Merging in missing trunk code#1
Open
Andrew Lighterink (alighterink) wants to merge 434 commits intonetsapiens:v3from
Open
Merging in missing trunk code#1Andrew Lighterink (alighterink) wants to merge 434 commits intonetsapiens:v3from
Andrew Lighterink (alighterink) wants to merge 434 commits intonetsapiens:v3from
Conversation
…events` module (#298) - Generated TS types should not depend on Node types. - So let's force module resolution to take and read `events` from the NPM **events** module.
Co-authored-by: Kevin Venalainen <kevin.venalainen@around.co>
…ines if there are ,more than 1 codec in the media section
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Duplicate comments:
In `@package.json`:
- Around line 94-97: package.json declares Jest "^30.2.0" while ts-jest is
"^29.4.6", causing a major-version mismatch; fix by aligning the two: either set
"jest" to a 29.x series to match "ts-jest" (e.g., downgrade jest to ^29) or
update "ts-jest" to a 30.x release if one exists and supports TypeScript 5.9,
then run your package manager to update lockfiles and re-run tests to verify;
locate these entries in package.json ("jest" and "ts-jest") to make the change.
- Around line 34-36: The package exports for "./enhancedEvents" use the wrong
condition key "ortc" which prevents TypeScript from resolving the declaration;
update the export condition in the package.json entry for "./enhancedEvents" by
replacing the "ortc" condition with "types" so that the declaration
"./lib/enhancedEvents.d.ts" is exposed when consumers request types, keeping the
existing "default": "./lib/enhancedEvents.js" mapping intact.
- Fixes #141 - This PR replaces PR #359 but it's basically a copy&paste of it with some minimal cosmetic changes. So absolutely all credits to @6uliver. - Now we generate different RTP capabilities for sending and receiving and the only change in the public API is that `device.rtpCapabilities` getter is now deprecated and instead the app should use `device.recvRtpCapabilities` and `device.sendRtpCapabilities`.
authored-by: Astagor <astagor@gmail.com>
# Details - Fixes #369 - In receive transports, munge local SDP answer to set desired max SCTP message size (obtained from the mediasoup `Transport`'s SCTP parameters).
# Details - In a send `Transport` it returns the maximum DataChannel message size that it can send. - In a receive `Transport` it returns the maximum DataChannel message size that it can receive. - Note that it can return `undefined` (if DataChannels is not enabled).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
11 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary by CodeRabbit
Breaking Changes
New Features
CI / Tests
Documentation
Style / Tooling