Add Class of Device debugging info#30
Open
brett-lynnes wants to merge 1 commit intonettlep:masterfrom
Open
Conversation
Owner
|
Hi Brett, this all looks good, though I would suggest a formatting treatment to match the existing ggk codebase (mostly curly brace placement and switch/case indentation.) |
Author
|
ah yes, sorry about the formatting (our codebases don't match well at all,
and i auto-formatted portions of GGK accidentally a long time ago). i will
submit another request later with better formatting when i get the security
stuff working (Agent1 dbus hookups from app-land are working pretty well
with your server, but there were some modifications i had to make to mgmt).
next update should have mgmt flushed out a lot more and a better
encapsulation of security modes (holy crap BlueZ is a steaming pile of
garbage on this).
…On Thu, Nov 21, 2019 at 4:44 AM Paul Nettle ***@***.***> wrote:
Hi Brett, this all looks good, though I would suggest a formatting
treatment to match the existing ggk codebase (mostly curly brace placement
and switch/case indentation.)
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#30?email_source=notifications&email_token=AITJ6K7HTNYV7TH5EN4A52LQUZ7CFA5CNFSM4ITLM24KYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEE2DCII#issuecomment-557068577>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AITJ6KYZZ473MX2OWWNRS5TQUZ7CFANCNFSM4ITLM24A>
.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This puts a bunch of spam in HciAdapter.h (i may separate out the debug/display functions at a later date), but it does appear to parse the 24bit Class of Device correctly so you can see what your device is announcing itself as. As far as I can tell, the only ones out there who actually use this information are Apple devices. Other devices may use the CoD to figure out which icon to display your server as.