feat: a possible better way to enter password#59
Open
stceum wants to merge 1 commit intoneucn:masterfrom
Open
Conversation
unbyte
requested changes
Oct 7, 2024
| } | ||
|
|
||
| password := ctx.String("password") | ||
| if password == "" { |
Member
There was a problem hiding this comment.
如果使用者用 set 只是想把账号设置成 default 而不涉及密码的话,这样处理是有问题的
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
一种可能更好的输入密码的方式。
之前:(需要密码,该密码可能存在于 bash/zsh/... 历史记录中):
$ ipgw config account add -u xxxxxxx -p xxx...xxx # 可能不安全现在:
$ ipgw config account add -u xxxxxxx Enter Password: # 输入时不回显A possible better way to enter password.
previous (password is required which may exist in the bash/zsh/... history):
$ ipgw config account add -u xxxxxxx -p xxx...xxx # Potentially unsafecurrent:
$ ipgw config account add -u xxxxxxx Enter Password: # type in without echo