Make sure the value is always an Oembed object#7
Open
romaincazier wants to merge 2 commits intoneuerituale:masterfrom
Open
Make sure the value is always an Oembed object#7romaincazier wants to merge 2 commits intoneuerituale:masterfrom
romaincazier wants to merge 2 commits intoneuerituale:masterfrom
Conversation
Author
|
"$page->embed" // returns the url insteadAlso two notes: I don’t know how the search handles Pagefile/image’s custom field and something I saw when testing was that the |
Author
|
Actually I figured a way to have |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR removes the "_oembedObj" property and instead make sure the value is always an Oembed object with at least the properties
emptyandurl(what’s input in the field).The key functions (among other bits) to make this work with an InputfieldURL descendant were
FieldtypeOembed::sanitizeValueandInputfieldOembed::setAttributeValue.This resolves the issue with Pagefile/image’s custom field mentioned here.
Of course I invite you to examine first and also try before merging to make sure I didn’t miss something.
(I’m doing this first as I wanted to add the ability for the field to hold a local copy of the thumbnail, unless you’re also working on this?)