fix: offloading model layers to gpu and using flash_attn for gpu#75
Open
HeisenberG2575 wants to merge 1 commit intoneuphonic:mainfrom
Open
fix: offloading model layers to gpu and using flash_attn for gpu#75HeisenberG2575 wants to merge 1 commit intoneuphonic:mainfrom
HeisenberG2575 wants to merge 1 commit intoneuphonic:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context:
The
_load_backbonefunctions loads the neutts-air backbone for inference. While this function works as intended for CPU inference, GPU inference is slowed down due to faults in codeProblem:
Considering that
backbone_deviceis used to export the model to the appropriate device, "gpu" isn't a valid string for.to()hence users resort to the standard "cuda" or strings having "cuda" such as "cuda:0" as a prefix. The current if conditionsn_gpu_layers=-1 if backbone_device == "gpu" else 0and
flash_attn=True if backbone_device == "gpu" else Falsedo not have the intended effect of offloading the model to GPU and using flash-attention since the string is checked for "gpu"
Fix:
startswithmethod for strings ensures usage of "cuda" asbackbone_deviceleads to intended behaviourTODOs:
flash_attnand use ofn_gpu_layerswith gguf