Skip to content

Conversation

@niksirbi
Copy link
Member

@niksirbi niksirbi commented Sep 23, 2025

Description

What is this PR

  • Bug fix
  • Addition of a new feature
  • Other

Why is this PR needed?

We now also show a "dev" version of the docs (corresponding to the main branch), see #78, but the displayed release doesn't always make sense.

For example, if the latest tagged version is v0.3.3, setuptools_csm will label commits after that as v0.3.4.dev{N}+{commit-hash}. Our code in Sphinx's conf.py trims that to just v0.3.4 so it's not apparent that this is a development version of v0.3.4 and instead it looks like the release v0.3.4.

What does this PR do?

It changes the trimming logic such that the .dev suffix is preserved if present.
The hash is still removed. So the above example will be now displayed as v0.3.4.dev5 (number after dev varies).

References

#78

How has this PR been tested?

Local docs build.

Is this a breaking change?

No.

Does this PR require an update to the documentation?

No.

Checklist:

  • The code has been tested locally
  • Tests have been added to cover all new functionality
  • The documentation has been updated to reflect any changes
  • The code has been formatted with pre-commit

@niksirbi niksirbi marked this pull request as ready for review September 23, 2025 16:13
@JoeZiminski JoeZiminski merged commit b2b7035 into main Sep 23, 2025
3 checks passed
@JoeZiminski JoeZiminski deleted the display-dev-tag-in-release-name branch September 23, 2025 16:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants