Consolidate PR + default-branch validation into canonical ci.yml#51
Closed
neuron7xLab wants to merge 1 commit intomainfrom
Closed
Consolidate PR + default-branch validation into canonical ci.yml#51neuron7xLab wants to merge 1 commit intomainfrom
neuron7xLab wants to merge 1 commit intomainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
pr-gate.ymlandmain-validation.ymlinto a single canonical workflow.github.event.repository.default_branchrather than hardcoding a branch name.Description
.github/workflows/ci.ymlwhich consolidates PR, push-to-default-branch, andworkflow_dispatchvalidation and implements job-level default-branch guards,concurrency, and least-privilegepermissions..github/workflows/pr-gate.ymland.github/workflows/main-validation.ymland updated.github/workflows/README.mdto list the canonical workflows (ci.ymland preservedsecurity-deep.yml).ci.ymljobs include: Python quality/tests/build (black, ruff, mypy, pytest+coverage, coverage guardrail, build), dependency/security gates (pip-audit+ frontendnpm audit),apps/webfrontend checks (format, lint, tsc, jest, build),ui/dashboardchecks, Go tests (go test ./...), Rust fmt/clippy/tests/build (cargo), and Docker image build smoke tests../.github/actions/setup-tradepulse,package.jsonscripts,go.mod, Rust Cargo manifest) and relies on lockfiles for deterministic installs and caching where appropriate.Testing
go test ./...locally against the repo and it completed successfully (okreported bygo test).cargo test --manifest-path rust/tradepulse-accel/Cargo.tomllocally and the Rust unit tests completed successfully (7 passed).actionlintvia Docker to validate workflow YAMLs but the local environment lacked Docker, so that check could not be executed here (will run in GitHub-hosted runners or CI job where Docker is available).Codex Task