fix(test_integrity_v2): widen HRV subject request to absorb wfdb flake#168
Closed
neuron7x wants to merge 1 commit intoneuron7xLab:mainfrom
Closed
fix(test_integrity_v2): widen HRV subject request to absorb wfdb flake#168neuron7x wants to merge 1 commit intoneuron7xLab:mainfrom
neuron7x wants to merge 1 commit intoneuron7xLab:mainfrom
Conversation
TestHRV::test_gamma_in_range requested n_subjects=3 — exactly the floor enforced in HRVPhysioNetAdapter._ensure_loaded. A single PhysioNet/wfdb network glitch dropping one record made the test fail with "Insufficient HRV data: 2 subjects" (CI run 25184505044, Verify 3.12). Same SHA passed on Verify 3.10 and 3.11 — pure transient flake, not a Python-version regression. Raise the ask to 5 (margin of 2) so the test stays green when up to two records are skipped during _load(). Floor and physics are unchanged. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
5 tasks
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
TestHRV::test_gamma_in_rangeзапитуєn_subjects=3при_ensure_loadedfloor=3 — нульовий запас. Один пропущений PhysioNet/wfdb запис →RuntimeError: Insufficient HRV data: 2 subjects(run 25184505044, Verify 3.12). Той самий SHA пройшов на 3.10/3.11 — чистий мережевий flake, не Python-регресія.Test plan
Claim status
claim_status: derived
Pure CI hygiene PR — жодного нового вимірювального claim. Зміна лише виправляє test fixture брак запасу, повертає тест до попередньо встановленої поведінки. Floor enforcement (≥3 суб'єктів) і physics range залишаються тими ж, тож логіка випливає з вже існуючого канону.
🤖 Generated with Claude Code