Skip to content

Fix signed/unsigned type mismatch in DpcProcessor::ComputeResultImages #22

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
Copilot wants to merge 4 commits into
base: issue19_conan
Choose a base branch
from
Draft

Fix signed/unsigned type mismatch in DpcProcessor::ComputeResultImages #22

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
baad10b
Initial plan
Copilot Dec 4, 2025
6263d5f
Fix variable type: revert N to size_t, keep loop var as ptrdiff_t
Copilot Dec 4, 2025
363a904
Add explicit cast in loop condition to avoid signed/unsigned comparison
Copilot Dec 4, 2025
e97a0fc
Final update after addressing all feedback
Copilot Dec 4, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions _codeql_detected_source_root
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
.
4 changes: 2 additions & 2 deletions frameworks/ngi/nGIFramework/src/nGIProcessor.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -278,7 +278,7 @@ kipl::base::TImage<complex<float> ,2> DpcProcessor::ComputeHarmonicImage(kipl::b
void DpcProcessor::ComputeResultImages()
{
// Compute transmission image
const ptrdiff_t N=static_cast<ptrdiff_t>(openbeamDC.Size());
const size_t N=openbeamDC.Size();
complex<float> *pOpenBeamDC = openbeamDC.GetDataPtr();
complex<float> *pSampleDC = sampleDC.GetDataPtr();

Expand All @@ -293,7 +293,7 @@ void DpcProcessor::ComputeResultImages()
float *pPhaseContrast=phasecontrast.GetDataPtr();
float *pDarkField=darkfield.GetDataPtr();
#pragma omp parallel for
for (ptrdiff_t i=0; i<N; i++)
for (ptrdiff_t i=0; i<static_cast<ptrdiff_t>(N); i++)
{
pTransmision[i]=abs(pSampleDC[i])/abs(pOpenBeamDC[i]);
if (mConfig.process.bUseAmplLimits) {
Expand Down