feat: add extra env/volumes/volumeMounts to implement the ability to …#513
feat: add extra env/volumes/volumeMounts to implement the ability to …#513toyhoshi wants to merge 1 commit intoneuvector:masterfrom
Conversation
|
@venkateshjayagopal any feedback on this one? |
| projected: | ||
| defaultMode: 420 | ||
| sources: | ||
| - configMap: |
There was a problem hiding this comment.
I was really looking forward to this functionality. Nice PR! Should we set it to a secret rather than a configmap since the ca bundle can be potentially sensitive information ?
There was a problem hiding this comment.
Should we set it to a secret rather than a configmap since the ca bundle can be potentially sensitive information ?
CA Bundles cannot contain sensitive information. Certificate data is inherently public (your browser receives this from all TLS sites)
There was a problem hiding this comment.
Having said that, defaulting the module's values for this feels odd. Might be better to move the core values to an example in a doc? Or comment it out here and leave extraVolumeMounts: []
| projected: | ||
| defaultMode: 420 | ||
| sources: | ||
| - configMap: |
There was a problem hiding this comment.
same note as above swapping from configMap to secret
There was a problem hiding this comment.
Should we set it to a secret rather than a configmap since the ca bundle can be potentially sensitive information ?
CA Bundles cannot contain sensitive information. Certificate data is inherently public (your browser receives this from all TLS sites)
3 participants
this change resolves #193 by adding extraEnv, extraVolume and extraVolumeMounts.
Signed-off by: Marco Varagnolo marco.varagnolo@gmail.com