NVSHAS-10267 to create neuvector-binding-secret-controller always#561
Open
selvamt94 wants to merge 1 commit intoneuvector:masterfrom
Open
NVSHAS-10267 to create neuvector-binding-secret-controller always#561selvamt94 wants to merge 1 commit intoneuvector:masterfrom
selvamt94 wants to merge 1 commit intoneuvector:masterfrom
Conversation
selvamt94
requested review from
esther-suse,
holyspectral and
venkateshjayagopal
and removed request for
esther-suse
|
|
||
| --- | ||
|
|
||
| {{- if $oc3 }} |
Contributor
There was a problem hiding this comment.
Is the change in charts/core/templates/rolebinding-least.yaml required?
It looks like originally line 175~202(for neuvector-binding-secret-controller) is already outside of
{{- if .Values.internal.autoGenerateCert }} ## line 37
....
{{- end }} ## line 130
(i.e. role/rolebinding neuvector-binding-secret-controller is always created in least-privileged deployment)
Am I wrong?
Contributor
Author
There was a problem hiding this comment.
My mistake, it is not required. Let me roll back the changes for rolebinding-least.yaml. Thanks for finding it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
neuvector-binding-secret-controller role and rolebinding need to be created irrespective autoGenerateCert flag status.