Skip to content

Conversation

@TimPansino
Copy link
Contributor

@TimPansino TimPansino commented Nov 4, 2025

Overview

  • Add ability to supply an instance of BaseException as an argument to notice_error and have it be unpacked into an exception tuple before processing.
  • Add tests to ensure the behavior reports the correct exception even when sys.exc_info() would return a different one.

Related Issues

Rework of #1564

@TimPansino TimPansino requested a review from a team as a code owner November 4, 2025 00:33
@github-actions
Copy link

github-actions bot commented Nov 4, 2025

MegaLinter analysis: Success

Descriptor Linter Files Fixed Errors Warnings Elapsed time
✅ ACTION actionlint 7 0 0 0.91s
✅ MARKDOWN markdownlint 7 0 0 0 1.37s
✅ PYTHON ruff 949 0 0 0 1.02s
✅ PYTHON ruff-format 949 0 0 0 0.37s
✅ YAML prettier 15 0 0 0 1.52s
✅ YAML v8r 15 0 0 6.18s
✅ YAML yamllint 15 0 0 0.71s

See detailed reports in MegaLinter artifacts

MegaLinter is graciously provided by OX Security

@codecov-commenter
Copy link

codecov-commenter commented Nov 4, 2025

Codecov Report

❌ Patch coverage is 60.00000% with 4 lines in your changes missing coverage. Please review.
✅ Project coverage is 81.82%. Comparing base (fa7f3ca) to head (b8d36a4).

Files with missing lines Patch % Lines
newrelic/core/stats_engine.py 20.00% 2 Missing and 2 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1571      +/-   ##
==========================================
- Coverage   81.85%   81.82%   -0.03%     
==========================================
  Files         207      207              
  Lines       24008    24012       +4     
  Branches     3812     3814       +2     
==========================================
- Hits        19651    19648       -3     
- Misses       3088     3092       +4     
- Partials     1269     1272       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@mergify mergify bot added the tests-failing Tests failing in CI. label Nov 14, 2025
@mergify mergify bot removed the tests-failing Tests failing in CI. label Nov 17, 2025
@mergify mergify bot added the tests-failing Tests failing in CI. label Nov 18, 2025
@mergify mergify bot removed the tests-failing Tests failing in CI. label Nov 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants