Update repo to work on NEXT-100 #54
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gonzaponte
force-pushed
the
next100-update
branch
2 times, most recently
from
ee05245 to
cdc3588
Compare
gonzaponte
force-pushed
the
next100-update
branch
4 times, most recently
from
a66b78e to
cdbc060
Compare
bpalmeiro
reviewed
Jul 25, 2025
Member
bpalmeiro
left a comment
bpalmeiro
left a comment
There was a problem hiding this comment.
First round of comments. Good job so far!
carhc
force-pushed
the
next100-update
branch
2 times, most recently
from
b71295e to
5a70212
Compare
bpalmeiro
approved these changes
Jul 29, 2025
Member
bpalmeiro
left a comment
bpalmeiro
left a comment
There was a problem hiding this comment.
Long-needed update for the code to run detector independently. Changes are profound and sensible, improving also flaky loose ends pending from before. Good job.
For some reason time evolution was tested separately
gonzaponte
force-pushed
the
next100-update
branch
from
02f8a07 to
6837ff4
Compare
Collaborator
Author
|
rebased. I'm trying to fix the issue with GHA, but this is ready to be merged. |
Collaborator
Author
|
Ignore GHA failure, please merge. |
gonzaponte
force-pushed
the
next100-update
branch
from
6837ff4 to
0186efc
Compare
mcidlaso
added a commit
that referenced
this pull request
Nov 21, 2025
#55 [author: gonzaponte] We pushed through #54 to get everything asap. Now we fix the tests. The results seem to depend on the machine somehow, so for now this is ignored. [reviewer: carhc] Nice job! I have one small issue, thought. I suggest removing the x_range, y_range in the config files since they no longer play any role on the evolution computation, but maybe this is not the most suitable PR for that since that does not affect the tests. Other than that, I think it's just the commented assert on test_scrip_runs_and_produces_correct_outputs, apparently machine-dependent. How should we proceed now?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Includes a hack for NEXT-100, since the table DETECTOR_GEO is currently empty on the database.