fix: connectivity service impl #15820
Open
+274
−223
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
alperozturk96
force-pushed
the
fix/internet-walled-check-logic
branch
from
5c72334 to
d783dfe
Compare
4 tasks
alperozturk96
changed the title
alperozturk96
force-pushed
the
fix/internet-walled-check-logic
branch
2 times, most recently
from
e973ca8 to
facd5b2
Compare
alperozturk96
commented
Oct 21, 2025
app/src/main/java/com/nextcloud/client/network/ConnectivityServiceImpl.java
Show resolved
Hide resolved
alperozturk96
commented
Oct 21, 2025
app/src/main/java/com/nextcloud/client/network/ConnectivityServiceImpl.java
Show resolved
Hide resolved
alperozturk96
commented
Oct 21, 2025
app/src/main/java/com/nextcloud/client/network/ConnectivityServiceImpl.java
Show resolved
Hide resolved
alperozturk96
commented
Oct 21, 2025
app/src/main/java/com/nextcloud/client/network/ConnectivityServiceImpl.java
Outdated
Show resolved
Hide resolved
tobiasKaminsky
requested changes
Oct 22, 2025
app/src/main/java/com/nextcloud/client/network/ConnectivityServiceImpl.java
Outdated
Show resolved
Hide resolved
alperozturk96
force-pushed
the
fix/internet-walled-check-logic
branch
from
facd5b2 to
d1c1436
Compare
alperozturk96
force-pushed
the
fix/internet-walled-check-logic
branch
2 times, most recently
from
bb34886 to
ae23afa
Compare
alperozturk96
commented
Nov 17, 2025
app/src/main/java/com/nextcloud/client/network/ConnectivityServiceImpl.java
Show resolved
Hide resolved
alperozturk96
force-pushed
the
fix/internet-walled-check-logic
branch
from
60e8b7d to
47974ec
Compare
|
APK file: https://www.kaminsky.me/nc-dev/android-artifacts/15820.apk |
Signed-off-by: alperozturk <alper_ozturk@proton.me>
Signed-off-by: alperozturk <alper_ozturk@proton.me>
Signed-off-by: alperozturk <alper_ozturk@proton.me>
alperozturk96
force-pushed
the
fix/internet-walled-check-logic
branch
from
327cde9 to
2d4633d
Compare
|
test-Unit test failed: https://www.kaminsky.me/nc-dev/android-integrationTests/15820-Unit-test-07-46 |
|
blue-Light-Screenshot test failed, but no output was generated. Maybe a preliminary stage failed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #14681
Deduplicates
isNetworkAndServerAvailablelogicRemoves
c.isWifi() && !c.isMetered()from internet walled logic sinceisConnectedalready covers local internet and internet accessImplements
ConnectivityManager.NetworkCallbackfor better network state listeningRemoves deprecated logics
Adds better documentation